Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtorc: Cleanup unused code #15508

Merged
merged 1 commit into from
Mar 18, 2024
Merged

vtorc: Cleanup unused code #15508

merged 1 commit into from
Mar 18, 2024

Conversation

dbussink
Copy link
Contributor

This used deadcode to find all unused code inside vtorc and cleans it up. Ran it both with and without the -test flag to also find code that is only exercised from tests and not from anywhere else.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
vtorc: Cleanup unused code
22bbc8a 
This used `deadcode` to find all unused code inside `vtorc` and cleans
it up. Ran it both with and without the `-test` flag to also find code
that is only exercised from tests and not from anywhere else.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Type: Internal Cleanup Component: VTorc Vitess Orchestrator integration labels Mar 18, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 18, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 18, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 18, 2024
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 18, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (4d4793d) to head (22bbc8a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15508      +/-   ##
==========================================
- Coverage   65.67%   65.66%   -0.02%     
==========================================
  Files        1563     1561       -2     
  Lines      194474   194272     -202     
==========================================
- Hits       127727   127560     -167     
+ Misses      66747    66712      -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbussink dbussink merged commit 52ca497 into vitessio:main Mar 18, 2024
107 of 114 checks passed
@dbussink dbussink deleted the dbussink/vtorc-cleanup branch March 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @shlomi-noach @GuptaManan100